Compass 23919 Onboarding flow implement custom bridge method #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export async function isRenderingInOnboardingFlow(): Promise<boolean> { | ||
| try { | ||
| const context = await view.getContext(); | ||
| return context.extension.renderingLocation === 'onboardingFlow'; |
There was a problem hiding this comment.
I would add a TODO: comment here with a link to the task to import the package
There was a problem hiding this comment.
I think due to the open source nature of this repo, it may be impossible to import that package which is not published to npm
svankayalapati-atlassian
requested review from
dlapierreatlassian and
PatrickAtlassian
PatrickAtlassian
approved these changes
Jan 22, 2025
svankayalapati-atlassian
deleted the
COMPASS-23919-gitlab-implement-custom-bridge-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added helper function to know if in onboarding flow and call bridge method for error cases as well as if import is successful.
Checklist
Please ensure that each of these items has been addressed: